Statically link libc++abi into libc++ #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent C++ links from breaking when llvm/llvm-project#101259 lands, as that removes -lc++abi and -lunwind from the linker command-line.
smithp35
approved these changes
Sep 3, 2024
Contributor
smithp35
left a comment
smithp35
left a comment
There was a problem hiding this comment.
LGTM thanks for making the change.
dcandler
added a commit
to dcandler/LLVM-embedded-toolchain-for-Arm
that referenced
this pull request
Sep 10, 2024
The following changes to LLVM ET were made in response to changes in LLVM which happened after the LLVM 19 branch, and therefore do not need to be on our branch either: Statically link libc++abi into libc++ (ARM-software#483) e80e252 Update a downstream patch for altered context (NFC) d95a4fa Fix a patch conflict in libc++ tests. 7616f8c Do not default to linking crt0 when using crt0-semihosting (ARM-software#460) 39523a0 Remove patch since llvm sort.pass.cpp is already marked as a long test (ARM-software#458) 3b32a82
dcandler
added a commit
to dcandler/LLVM-embedded-toolchain-for-Arm
that referenced
this pull request
Sep 10, 2024
The following changes to LLVM ET were made in response to changes in LLVM which happened after the LLVM 19 branch, and therefore do not need to be on our branch either: Statically link libc++abi into libc++ (ARM-software#483) e80e252 Update a downstream patch for altered context (NFC) d95a4fa Fix a patch conflict in libc++ tests. 7616f8c Do not default to linking crt0 when using crt0-semihosting (ARM-software#460) 39523a0 Remove patch since llvm sort.pass.cpp is already marked as a long test (ARM-software#458) 3b32a82 Update patch file for libc++ tests with picolibc, to mark sort test as long one (ARM-software#457) 9a53fc9
dcandler
added a commit
to dcandler/LLVM-embedded-toolchain-for-Arm
that referenced
this pull request
Sep 12, 2024
The following changes to LLVM ET were made in response to changes in LLVM which happened after the LLVM 19 branch, and therefore do not need to be on our branch either: Statically link libc++abi into libc++ (ARM-software#483) e80e252 Update a downstream patch for altered context (NFC) d95a4fa Fix a patch conflict in libc++ tests. 7616f8c Do not default to linking crt0 when using crt0-semihosting (ARM-software#460) 39523a0 Remove patch since llvm sort.pass.cpp is already marked as a long test (ARM-software#458) 3b32a82 Update patch file for libc++ tests with picolibc, to mark sort test as long one (ARM-software#457) 9a53fc9
dcandler
added a commit
that referenced
this pull request
Sep 16, 2024
The following changes to LLVM ET were made in response to changes in LLVM which happened after the LLVM 19 branch, and therefore do not need to be on our branch either: Statically link libc++abi into libc++ (#483) e80e252 Update a downstream patch for altered context (NFC) d95a4fa Fix a patch conflict in libc++ tests. 7616f8c Do not default to linking crt0 when using crt0-semihosting (#460) 39523a0 Remove patch since llvm sort.pass.cpp is already marked as a long test (#458) 3b32a82 Update patch file for libc++ tests with picolibc, to mark sort test as long one (#457) 9a53fc9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent C++ links from breaking when
llvm/llvm-project#101259 lands, as that removes -lc++abi and -lunwind from the linker command-line.